New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/filestore: do not free event if not added #16235

Merged
merged 2 commits into from Jul 10, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jul 10, 2017

this fixes the regression introduced by #16201

common/Timer: return false if event not added
Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov requested review from liewegas and jdurgin Jul 10, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov changed the title from os/filestore: do not double free event not added to os/filestore: do not free event if not added Jul 10, 2017

os/filestore: do not free event not added
if an event fails to be added, it's freed by the callee. so we should
not try to free it again. that address could be re-used by the
allocator, to we might be freeing an irrelevent event.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov added this to the luminous milestone Jul 10, 2017

@tchaikov tchaikov added the needs-qa label Jul 10, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 10, 2017

@liewegas liewegas merged commit 7f03169 into ceph:master Jul 10, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-timer branch Jul 11, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment