New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-disk: change the lockbox partition number to 5 #16247

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
3 participants
@shangzhong
Contributor

shangzhong commented Jul 10, 2017

@shangzhong

This comment has been minimized.

Contributor

shangzhong commented Jul 11, 2017

test this please

@shangzhong

This comment has been minimized.

Contributor

shangzhong commented Jul 11, 2017

when we use ceph-disk tool to prepare an osd device with --dmcrypt option, and both --block.db and --block.wal are specified to be the same whole device, the ceph-disk will fail.

The root cause is that lockbox partition and block.db partition are using the same number 3,and the block.wal partition number was set to 4 as default.

So the lockbox partition number should be change to 5 as default.

@tchaikov tchaikov self-requested a review Jul 11, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 17, 2017

nit, the fixes line should be

Fixes: http://tracker.ceph.com/issues/20556

which sits right before your "Signed-off-by" line.

@tchaikov tchaikov requested a review from Jul 17, 2017

@tchaikov tchaikov added this to the luminous milestone Jul 17, 2017

@ghost

ghost approved these changes Jul 17, 2017

@shangzhong

This comment has been minimized.

Contributor

shangzhong commented Jul 17, 2017

Thanks Kefu Chai, it's OK now.

ceph-disk: change the lockbox partition number to 5
Fixes: http://tracker.ceph.com/issues/20556
Signed-off-by: Shangzhong Zhu <zhu.shangzhong@zte.com.cn>
@shangzhong

This comment has been minimized.

Contributor

shangzhong commented Jul 18, 2017

Only remove the blank line between the "Signed-off-by" line and "Fixes" line in the commit message.

@tchaikov tchaikov merged commit 7a497c3 into ceph:master Jul 24, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@shangzhong shangzhong deleted the shangzhong:wip-20556 branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment