New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: add service map registration #16251

Merged
merged 1 commit into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@mattbenjamin
Contributor

mattbenjamin commented Jul 11, 2017

Add static service map registration for librgw/NFS. In this
verision registration is unconditional (e.g., unit tests would
register) and, in addition, since there is no API change, we
don't know anything about the upper-layer client.

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

@mattbenjamin mattbenjamin added the rgw label Jul 11, 2017

@mattbenjamin mattbenjamin requested a review from yehudasa Jul 11, 2017

@@ -545,6 +552,12 @@ namespace rgw {
fe->run();
r = store->register_to_service_map("rgwlib (NFS)", service_map_meta);

This comment has been minimized.

@liewegas

liewegas Jul 12, 2017

Member

"rgw-nfs" maybe?

fec = new RGWFrontendConfig("rgwlib");
fe = new RGWLibFrontend(env, fec);
map<string, string> service_map_meta;
service_map_meta["pid"] = stringify(getpid());
service_map_meta["frontend_type#" + fe_count] = "rgwlib (NFS)";

This comment has been minimized.

@liewegas

liewegas Jul 12, 2017

Member

same here.. this seems awkward to compare against

This comment has been minimized.

@mattbenjamin
rgw_file: add service map registration
Add static service map registration for librgw/NFS.  In this
verision registration is unconditional (e.g., unit tests would
register) and, in addition, since there is no API change, we
don't know anything about the upper-layer client.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jul 13, 2017

@liewegas updated

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 13, 2017

retest this please

@liewegas liewegas added the needs-qa label Jul 13, 2017

@liewegas liewegas added this to the luminous milestone Jul 13, 2017

@yuriw yuriw merged commit d02b00c into ceph:master Jul 17, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment