New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: only submit deferred if there is any #16269

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 11, 2017

We drop the lock, so it's possible another thread submits the pending.
(_deferred_submit_unlock assumes osr->deferred_pending != nullptr.)

Signed-off-by: Sage Weil sage@redhat.com

os/bluestore: only submit deferred if there is any
We drop the lock, so it's possible another thread submits the pending.
(_deferred_submit_unlock assumes osr->deferred_pending != nullptr.)

Signed-off-by: Sage Weil <sage@redhat.com>
@markhpc

This comment has been minimized.

Show comment
Hide comment
@markhpc

markhpc Jul 11, 2017

Member

This resolves a crash noted during 4k writes to bluestore with 16k min_alloc size.

Member

markhpc commented Jul 11, 2017

This resolves a crash noted during 4k writes to bluestore with 16k min_alloc size.

@markhpc markhpc self-requested a review Jul 11, 2017

@liewegas liewegas added this to the luminous milestone Jul 11, 2017

@liewegas liewegas merged commit 9b3c208 into ceph:master Jul 13, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-deferred-pending branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment