New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rbd-mirror: image sync should send NOCACHE advise flag #16285

Merged
merged 1 commit into from Sep 2, 2017

Conversation

Projects
None yet
3 participants
@smithfarm
Contributor

smithfarm commented Jul 12, 2017

rbd-mirror: set SEQUENTIAL and NOCACHE advise flags on image sync
Fixes: http://tracker.ceph.com/issues/17127
Signed-off-by: Mykola Golub <mgolub@mirantis.com>
(cherry picked from commit 1167865)

Conflicts:
    src/tools/rbd_mirror/image_sync/ObjectCopyRequest.cc (sparse reads are not
        being backported to jewel)

@smithfarm smithfarm self-assigned this Jul 12, 2017

@smithfarm smithfarm added this to the jewel milestone Jul 12, 2017

@smithfarm smithfarm added bug fix core rbd and removed core labels Jul 12, 2017

@smithfarm smithfarm requested review from dillaman and trociny Jul 12, 2017

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Jul 12, 2017

Contributor

Please review; I'm not confident about the conflict resolution.

Contributor

smithfarm commented Jul 12, 2017

Please review; I'm not confident about the conflict resolution.

@trociny

LGTM

@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Sep 2, 2017

Contributor

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-44

Please review.

Contributor

smithfarm commented Sep 2, 2017

@dillaman This passed an rbd suite at http://tracker.ceph.com/issues/20613#note-44

Please review.

@dillaman

lgtm

@smithfarm smithfarm merged commit bab3248 into ceph:jewel Sep 2, 2017

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-18137-jewel branch Sep 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment