New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jewel: rgw: cls: ceph::timespan tag_timeout wrong units #16289

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
3 participants
@cbodley
Contributor

cbodley commented Jul 12, 2017

rgw: cls: ceph::timespan tag_timeout wrong units
In rgw_dir_suggest(), the ceph::timespan tag_timeout is intended
to be a value in seconds, but has been taken as something much
smaller (millis?).  The incorrect time scale likely induces a race
condition with object deletes.

Fixes: http://tracker.ceph.com/issues/20380

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit e6763eb)

@cbodley cbodley added this to the jewel milestone Jul 12, 2017

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Jul 12, 2017

Contributor

@casey thanks, casey

Contributor

mattbenjamin commented Jul 12, 2017

@casey thanks, casey

@mattbenjamin

lgtm

@mattbenjamin

This comment has been minimized.

Show comment
Hide comment
@mattbenjamin

mattbenjamin Jul 20, 2017

Contributor

retest this please

Contributor

mattbenjamin commented Jul 20, 2017

retest this please

@mattbenjamin mattbenjamin merged commit 8db71d7 into ceph:jewel Jul 20, 2017

3 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@smithfarm

This comment has been minimized.

Show comment
Hide comment
@smithfarm

smithfarm Aug 3, 2017

Contributor

http://tracker.ceph.com/issues/18470#note-3 says: "The original regression has been introduced via #6501 and is present in Jewel 10.2.7. We should have this backported to Jewel since http://tracker.ceph.com/issues/20380 would introduce stale bucket index entries and running bucket check would be catastrophical without this tracker being backported to Jewel."

Contributor

smithfarm commented Aug 3, 2017

http://tracker.ceph.com/issues/18470#note-3 says: "The original regression has been introduced via #6501 and is present in Jewel 10.2.7. We should have this backported to Jewel since http://tracker.ceph.com/issues/20380 would introduce stale bucket index entries and running bucket check would be catastrophical without this tracker being backported to Jewel."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment