New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add instructions for replacing an OSD #16314

Merged
merged 1 commit into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Jul 13, 2017

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

this PR depends on #15432

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

retest this please.

@alfredodeza

This is great. Thanks for taking the time to provide an update

Replacing an OSD
----------------
When disk fails, or if an admnistrator wants to reprovision OSDs with a new backend, for instance, for switching from XFS to BlueStore, OSDs need to be replaced. Unlike purging an OSD, we need to keep the replaced OSD's id and CRUSH map entry intact after killing it for the replacement.

This comment has been minimized.

@alfredodeza

alfredodeza Jul 18, 2017

Contributor

This is either "When a disk fails" or "When disks fail"

This comment has been minimized.

@alfredodeza

alfredodeza Jul 18, 2017

Contributor

there is no need for using "we", and this can be left as it is written in the rest of the paragraph: "Unlike purging, replaced OSD ID's and CRUSH map entry need to be kept intact [...]"

ceph osd destroy {id} --yes-i-really-mean-it
#. Zap a disk for the new OSD, if the disk was used before for other purposes. It's not necessary for a new replacement disk::

This comment has been minimized.

@alfredodeza

alfredodeza Jul 18, 2017

Contributor

this is either "for a new disk" or "when replacing with a new disk"

ceph-disk zap /dev/sdX
#. Prepare the disk for the replacement by using the previously destroyed OSD id::

This comment has been minimized.

@alfredodeza

alfredodeza Jul 18, 2017

Contributor

s/for the replacement/for replacement/g

Replacing an OSD
----------------
When disk fails, or if an admnistrator wants to reprovision OSDs with a new backend, for instance, for switching from XFS to BlueStore, OSDs need to be replaced. Unlike purging an OSD, we need to keep the replaced OSD's id and CRUSH map entry intact after killing it for the replacement.

This comment has been minimized.

@jdurgin

jdurgin Jul 18, 2017

Member

link to ceph man page for 'osd purge' - this is the first mention of it

This comment has been minimized.

@tchaikov

tchaikov Jul 19, 2017

Contributor

i am revising the subsection of "Removing OSD" and will link to ceph(8) from there instead.

doc: add instructions for replacing an OSD
* 8/ceph.rst: `rm` subcommand removes osd from osdmap, not the cluster.
  the latter is more ambiguous in different contexts.
* rados/operations/add-or-rm-osds.rst: add a subsection of "Replacing an
  OSD". update the subsection of "Removing the OSD" with "ceph osd
  purge" command
* release-notes.rst: link from it to the new subsection in add-or-rm-osds.rst

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 19, 2017

@jdurgin @alfredodeza fixed and repushed. please see commit message for the changelog.

@tchaikov tchaikov added this to the luminous milestone Jul 19, 2017

@tchaikov tchaikov merged commit c3fba3c into ceph:master Jul 19, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-doc-replace-osd branch Jul 19, 2017

@scienceluo

This comment has been minimized.

Contributor

scienceluo commented on doc/rados/operations/add-or-rm-osds.rst in a0d9359 Jul 20, 2017

“purge subcommand” is a dead link?

This comment has been minimized.

Contributor

tchaikov replied Jul 20, 2017

thanks, fixed by #16437

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment