New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: misc fix and cleanups #16315

Merged
merged 4 commits into from Jul 17, 2017

Conversation

Projects
None yet
4 participants
@majianpeng
Member

majianpeng commented Jul 13, 2017

No description provided.

os/bluestore/BlueStore: using bufferlist::copy avoid rebuild.
If using bufferlist::get_contiguous, there is maybe rebuild whic cause
redundat memcopy. And bufferlist::copy can do the same function.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jul 13, 2017

Contributor

retest this please.

Contributor

tchaikov commented Jul 13, 2017

retest this please.

majianpeng added some commits Jul 13, 2017

os/bluestore/BlueStore: using buffprt::zero rather than memset.
Just for the code to look consistent

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
os/bluestore/BlueStore: no need to recalc.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
os/bluestore/BlueStore: remove useless judgement.
In fact logger is never null.

Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@tchaikov tchaikov added the needs-qa label Jul 14, 2017

@liewegas liewegas changed the title from Bluestore misc fix and cleanups. to os/bluestore: misc fix and cleanups Jul 14, 2017

@liewegas liewegas merged commit 1a0d645 into ceph:master Jul 17, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment