New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/workunits/ceph-helpers: test wait_for_health_ok differently #16317

Merged
merged 1 commit into from Jul 13, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jul 13, 2017

0 OSDs is not an error anymore in the new health checking implemented by
OSDMap::check_health(). this case was treated as an error before, see
OSDMonitor::get_health(). but an osdmap without any OSD is fine, i
think. but an osdmap with 3 OSDs, but all of them are down and out, this
is an error. and we do report this as an error. so, let's update the
test instead.

Signed-off-by: Kefu Chai kchai@redhat.com

qa/workunits/ceph-helpers: test wait_for_health_ok differently
0 OSDs is not an error anymore in the new health checking implemented by
OSDMap::check_health(). this case was treated as an error before, see
OSDMonitor::get_health(). but an osdmap without any OSD is fine, i
think. but an osdmap with 3 OSDs, but all of them are down and out, this
is an error. and we do report this as an error. so, let's update the
test instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

[ RUN      ] ObjectStore/StoreTest.SimpleCloneTest/0
...
Invalid rm coll

the test timed out, see https://jenkins.ceph.com/job/ceph-pull-requests/28505/console

retest this please.

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Jul 13, 2017

retest this please.

@tchaikov tchaikov requested a review from Jul 13, 2017

@ghost

ghost approved these changes Jul 13, 2017

@Liuchang0812

This comment has been minimized.

Contributor

Liuchang0812 commented Jul 13, 2017

👍 100% tests passed, 0 tests failed out of 178

@tchaikov tchaikov merged commit 771e2fa into ceph:master Jul 13, 2017

3 of 4 checks passed

make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-0-osd-is-not-an-error branch Jul 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment