New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test,mon,msg: kill clang analyzer warnings #16320

Merged
merged 3 commits into from Jul 14, 2017

Conversation

Projects
None yet
4 participants
@tchaikov
Contributor

tchaikov commented Jul 13, 2017

No description provided.

@tchaikov tchaikov added the cleanup label Jul 13, 2017

@tchaikov tchaikov requested review from yuyuyu101 and badone Jul 13, 2017

@tchaikov tchaikov added the needs-qa label Jul 13, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

retest this please.

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

@liewegas please drop this PR from your test branch. one of the commits fails to compile.

tchaikov added some commits Jul 13, 2017

test: test_c_headers: silence clang analyzer warnings
this silences clang analyzer's warnings like:

Value stored to 'ret' is never read

Signed-off-by: Kefu Chai <kchai@redhat.com>
msg/async/rdma: return stored errno on error
otherwise the errno would be overwritten, and we are returning 0 or the
errno set by ::close()

Signed-off-by: Kefu Chai <kchai@redhat.com>
mon: do not assign to never-read variable
this silences clang analyzer's warning of

Value stored to 'err' is never read

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 13, 2017

and the offending commit is fixed and pushed

@badone

badone approved these changes Jul 13, 2017

LGTM

@tchaikov

This comment has been minimized.

@tchaikov tchaikov merged commit cb71f18 into ceph:master Jul 14, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-clang-analyzer-warnings branch Jul 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment