New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: skip crush smoke test when running under valgrind #16346

Merged
merged 2 commits into from Jul 17, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 14, 2017

Valgrind tries to analyze the forked child process, and is slow enough
that it times out pretty reliably.

http://tracker.ceph.com/issues/20602

liewegas added some commits Jul 14, 2017

mon: add mon_osd_crush_smoke_test=true
This option allows us to disable the crush smoke test when creating pools,
injecting crush maps, or making other changes.  DANGER DANGER.

Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites: disable mon crush smoke test with valgrind
Valgrind runs itself on forked children, and does its cleanup when they
complete, and this is slow... slow enough that it frequently makes the
test time out.

Valgrind let's you ignore child *processes* that you exec, but I can't
find a way to skip forked children in the same address space.

Work around this by skip this validation when running under valgrind.

Fixes: http://tracker.ceph.com/issues/20602
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas requested a review from tchaikov Jul 14, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 14, 2017

Note this will likely get rebased on top of #16211 with the config option marked DEV.

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 17, 2017

retest this please

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 17, 2017

retest this please

@tchaikov tchaikov merged commit c142f25 into ceph:master Jul 17, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-20602 branch Jul 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment