New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph: allow '-' with -i and -o for stdin/stdout #16359

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 17, 2017

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from alfredodeza Jul 17, 2017

@liewegas liewegas added the core label Jul 17, 2017

@liewegas liewegas added this to the luminous milestone Jul 17, 2017

@alfredodeza

This looks good to me. Can you update the help so that it shows this is possible? Like:

parser.add_argument('-i', '--in-file', dest='input_file',
                    help='input filename or "-" to read from stdin')
parser.add_argument('-o', '--out-file', dest='output_file',
                    help='output filename or "-" to write to stdout')
@liewegas

This comment has been minimized.

Member

liewegas commented Jul 17, 2017

ceph: allow '-' with -i and -o for stdin/stdout
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 81ae434 into ceph:master Jul 18, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-cli-stdinout branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment