Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: rbd mirroring status page #16360

Merged
merged 23 commits into from Jul 24, 2017

Conversation

Projects
None yet
3 participants
@dillaman
Copy link
Contributor

dillaman commented Jul 17, 2017

TODO

  • dynamically generated nav bar error/warning counts
  • allow admin to optionally see error/warning callouts
@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Jul 17, 2017

screenshot from 2017-07-17 01-48-28
screenshot from 2017-07-17 01-48-35
screenshot from 2017-07-17 01-48-41

@dillaman dillaman added this to the luminous milestone Jul 17, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Jul 17, 2017

Very cool 😎

@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Jul 17, 2017

@jcsp still need to dynamically populate the nav bar warning/error counts and I would love to figure out a good way to display the daemon error/warning callouts. I wanted to have the tables dynamically expand by a row when you click an expand icon in a given daemon row, but requires additional JS-fu.

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jul 17, 2017

awesome

@dillaman dillaman force-pushed the dillaman:wip-rbd-mirror-service-daemon branch 2 times, most recently from 03e8182 to 4a02301 Jul 17, 2017

@dillaman dillaman changed the title [DNM] mgr/dashboard: rbd mirroring status page mgr/dashboard: rbd mirroring status page Jul 17, 2017

@dillaman dillaman requested a review from jcsp Jul 17, 2017

dillaman added some commits Jul 10, 2017

librados: preprocessor define to determine if service management supp…
…orted

This will be needed for out-of-tree applications like tcmu-runner.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mon: corrected typo in service daemon status
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: skeleton integration with service daemon API
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: convert ImageDeleter to template
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: prevent image health status from ping-ponging during re-a…
…ttempt

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librados_test_stub: added service daemon API methods
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: service daemon status formatter
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: preserve pool replayer instance after errors
This will help reduce ping-ponging of any potential callout error
notifications.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: service daemon callout for cluster watcher issues
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: service daemon callouts and attributes for pool replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: service daemon attributes for instance replayer
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
rbd-mirror: missing remote primary should result in warning health
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: sidebar tree should match current selection
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: move rbd pools to a sub-menu item
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: rbd pool image view should use dynamic data table
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: moved short_version formatter to common location
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
librbd: bypass large image creation check of object-map disabled
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: initial block mirroring status page
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

dillaman added some commits Jul 13, 2017

mgr/dashboard: tweak CSS to allow dataTables to be semi-readable
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: incorporate RBD mirror image status listing
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: integrate rbd mirroring daemon and pool stats
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: move mirroring service data logic to common helpers
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
mgr/dashboard: dynamically populate mirroring warning/errors
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-rbd-mirror-service-daemon branch from 4a02301 to a7dd68e Jul 18, 2017

@jcsp

jcsp approved these changes Jul 24, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor

jcsp commented Jul 24, 2017

@dillaman want to merge this or #16468 first? I'm guessing they conflict

@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Jul 24, 2017

@jcsp This one first, please -- if they conflict, I can manually resolve the other and merge.

@jcsp jcsp merged commit 34f4125 into ceph:master Jul 24, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-rbd-mirror-service-daemon branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.