New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: rephrase "wrongly marked me down" clog message #16365

Merged
merged 2 commits into from Jul 24, 2017

Conversation

Projects
None yet
6 participants
@jcsp
Contributor

jcsp commented Jul 17, 2017

Trying to avoid messages that phrase things in a cluster map-centric way, in favour of plain(er) english.

@jcsp jcsp added the core label Jul 17, 2017

@jcsp jcsp requested a review from jdurgin Jul 17, 2017

@gregsfortytwo

LGTM!
Do we want to write a doc page explaining it in a little more detail and add a link?

@@ -5,7 +5,7 @@ overrides:
mon warn on legacy crush tunables: false
mon debug unsafe allow tier with nonempty snaps: true
log-whitelist:
- wrongly marked me down

This comment has been minimized.

@jdurgin

jdurgin Jul 19, 2017

Member

won't we need to whitelist the old message for all these upgrade tests?

This comment has been minimized.

@jcsp

jcsp Jul 19, 2017

Contributor

urgh, you're right, I just did a global replacement.

@jcsp

This comment has been minimized.

Contributor

jcsp commented Jul 19, 2017

Updated to whitelist old+new variants in the upgrade/ suites

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 21, 2017

needs rebase

@yuriw

This comment has been minimized.

Contributor

yuriw commented Jul 21, 2017

@jcsp pls merge when ready

John Spray added some commits Jul 16, 2017

John Spray
osd: rephrase "wrongly marked me down" clog message
Rephrase as "Monitor daemon marked osd.<id> down, but it is
still running", which is more descriptive.  Demote the
epoch information to DEBUG level.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
qa: update whitelist for "wrongly marked me down"
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp merged commit 5026fff into ceph:master Jul 24, 2017

2 of 4 checks passed

make check running make check
Details
make check (arm64) Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@jcsp jcsp deleted the jcsp:wip-osd-marked-me-down branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment