New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: use a namespace for rgw reshard pool for upgrades as well #16368

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
4 participants
@theanalyst
Member

theanalyst commented Jul 17, 2017

We were previously (for dev & RC1) creating a new pool for bucket index
resharding during upgrades, moving to a namespace similar to new deployments since this
will avoid the creation of a new pool, also clarify the log message if
we do encounter the situation where the pool can't be accessed.

However there might be possible misconfigurations seen when upgrading
from luminous dev/RC1 releases to RC2 where a different pool for reshard
will still be used from the previous upgrade. Also need clarification
whether we need to bump up the zone params struct version number from 10
to 11

Fixes: http://tracker.ceph.com/issues/20289

rgw: clarify when encountering eacces for reshard list
Specify that we don't have access to the reshard pool when encountering
EACCESS.
TODO: get rgw's name and add that in the log message

Fixes http://tracker.ceph.com/issues/20289

Signed-off-by: Karol Mroz <kmroz@suse.de>
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>

@theanalyst theanalyst requested review from cbodley and oritwas Jul 17, 2017

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 17, 2017

@cbodley @oritwas reraising #16193 after incorporating the namsepace comment from tracker.. is this the way to proceed?

@@ -904,6 +904,7 @@ void RGWZoneParams::dump(Formatter *f) const
encode_json("log_pool", log_pool, f);
encode_json("intent_log_pool", intent_log_pool, f);
encode_json("usage_log_pool", usage_log_pool, f);
encode_json("reshard_pool", reshard_pool, f);

This comment has been minimized.

@cbodley

cbodley Jul 17, 2017

Contributor

it looks like reshard_pool is missing from RGWZoneParams::decode_json() too

This comment has been minimized.

@theanalyst

theanalyst Jul 17, 2017

Member

thanks! updating

This comment has been minimized.

@theanalyst

theanalyst Jul 17, 2017

Member

updated

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 17, 2017

Also need clarification whether we need to bump up the zone params struct version number from 10 to 11

i don't think that's necessary, since you're just changing the default value when decoding an older entry

theanalyst added some commits Jul 17, 2017

rgw: dump the reshard pool in rgw zone params json
So that the zone get/put commands display the reshard pool as well

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
rgw: move reshard pool to ns in log pool
Since the pool was introduced only in Luminous dev and RC releases we
can probably upgrade without the need to bump up the the struct version
numbers. This needs a pending release notes entry

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
PendingReleaseNotes: add a note on RGW's pool change for resharding
Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 17, 2017

@cbodley updated

@cbodley cbodley added the needs-qa label Jul 17, 2017

@theanalyst theanalyst modified the milestone: luminous Jul 17, 2017

@yuriw yuriw merged commit c95ab13 into ceph:master Jul 19, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment