Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cls/rbd: trash_list should be iterable #16372

Merged
merged 1 commit into from Jul 18, 2017

Conversation

Projects
None yet
2 participants
@dillaman
Copy link
Contributor

dillaman commented Jul 17, 2017

Fixes: http://tracker.ceph.com/issues/20643
Signed-off-by: Jason Dillaman dillaman@redhat.com

@dillaman dillaman added this to the luminous milestone Jul 17, 2017

cls/rbd: trash_list should be iterable
Fixes: http://tracker.ceph.com/issues/20643
Signed-off-by: Jason Dillaman <dillaman@redhat.com>

@dillaman dillaman force-pushed the dillaman:wip-20643 branch from e45a38e to b6c6f74 Jul 17, 2017

@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Jul 18, 2017

retest this please

@trociny
Copy link
Contributor

trociny left a comment

LGTM

@dillaman I suppose it would be nice to update librbd API too?

@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Jul 18, 2017

@trociny Perhaps -- I avoided it since the existing image list API method isn't iterable from the public API. The big concern was fixing the cls API before luminous since there was concern about blocking the PG for long periods of time iterating through a potentially unbounded collection.

@trociny trociny merged commit 547aa49 into ceph:master Jul 18, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@dillaman dillaman deleted the dillaman:wip-20643 branch Jul 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.