New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: s/ruleset/id/ in decompiled output; prevent compilation when ruleset != id #16400

merged 2 commits into from Jul 20, 2017


None yet
1 participant

liewegas commented Jul 18, 2017

No description provided.

liewegas added some commits Jul 17, 2017

crush: do not allow creating a rule with ruleset != rule id
Consolidate the add_rule rule id and ruleset arguments to be the same and
fix the callers.

Signed-off-by: Sage Weil <>
crush: s/ruleset/id/ in decompiled output
Moving away from the 'ruleset' terminology.

Signed-off-by: Sage Weil <>

@liewegas liewegas changed the title from osd/OSDMap: fix health warnings when mixed with crush device classes to crush: s/ruleset/id/ in decompiled output; prevent compilation when ruleset != id Jul 18, 2017

@liewegas liewegas requested a review from Jul 18, 2017

@liewegas liewegas added this to the luminous milestone Jul 18, 2017


This comment has been minimized.


liewegas commented Jul 18, 2017

retest this please


ghost approved these changes Jul 18, 2017

@liewegas liewegas merged commit 25bbe36 into ceph:master Jul 20, 2017

3 of 4 checks passed

make check (arm64) make check failed
Signed-off-by all commits in this PR are signed
Unmodified Submodules submodules for project are unmodified
make check make check succeeded

@liewegas liewegas deleted the liewegas:wip-crush-rule-id branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment