New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: fix pg ref leaks when osd shutdown #16408

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
8 participants
@yanghonggang
Contributor

yanghonggang commented Jul 19, 2017

@ceph-jenkins

This comment has been minimized.

Show comment
Hide comment
@ceph-jenkins

ceph-jenkins Jul 19, 2017

Collaborator

all commits in this PR are signed

Collaborator

ceph-jenkins commented Jul 19, 2017

all commits in this PR are signed

@yanghonggang yanghonggang changed the title from osd: fix pg refs leaked when osd shutdown problem to osd: fix pg refs leaked problem when osd shutdown Jul 19, 2017

@liewegas liewegas requested a review from tchaikov Jul 19, 2017

@liewegas liewegas added this to the luminous milestone Jul 19, 2017

Show outdated Hide outdated src/osd/PrimaryLogPG.cc

@tchaikov tchaikov changed the title from osd: fix pg refs leaked problem when osd shutdown to osd: fix pg ref leaks when osd shutdown Jul 20, 2017

@yanghonggang

This comment has been minimized.

Show comment
Hide comment
@yanghonggang

yanghonggang Jul 20, 2017

Contributor

@tchaikov ok, revert done.

Contributor

yanghonggang commented Jul 20, 2017

@tchaikov ok, revert done.

@tchaikov tchaikov added the needs-qa label Jul 20, 2017

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jul 20, 2017

Contributor

aside from the nit, lgtm.

Contributor

tchaikov commented Jul 20, 2017

aside from the nit, lgtm.

osd: fix pg ref leaks when osd shutdown
Fixes: http://tracker.ceph.com/issues/20684
Signed-off-by: Yang Honggang <joseph.yang@xtaotech.com>
@yanghonggang

This comment has been minimized.

Show comment
Hide comment
@yanghonggang

yanghonggang Jul 20, 2017

Contributor

@tchaikov comment is deleted.

Contributor

yanghonggang commented Jul 20, 2017

@tchaikov comment is deleted.

@yuriw yuriw merged commit 9fdd245 into ceph:master Jul 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment