New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore: move aio.h/cc from fs dir to bluestore dir #16409

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
5 participants
@liupan1111
Contributor

liupan1111 commented Jul 19, 2017

At this moment, only *Device(from bluestore) will call aio (io_submit) which is under fs dir. And for a fs, pwrite is used to write to a page cache. So I think it is better to move aio.h/cc from fs dir to bluestore dir.

Signed-off-by: Pan Liu wanjun.lp@alibaba-inc.com

aio: move aio.h/cc from fs dir to bluestore dir
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>

@liupan1111 liupan1111 requested a review from liewegas Jul 19, 2017

@liupan1111 liupan1111 changed the title from aio: move aio.h/cc from fs dir to bluestore dir to os/bluestore: move aio.h/cc from fs dir to bluestore dir Jul 19, 2017

@liewegas liewegas added the needs-qa label Jul 19, 2017

@tchaikov tchaikov added this to the luminous milestone Jul 20, 2017

@tchaikov

This comment has been minimized.

Show comment
Hide comment
@tchaikov

tchaikov Jul 20, 2017

Contributor

@liewegas i am adding this PR to luminous, as it will be a pain in future when we will need to backport changes to this file.

Contributor

tchaikov commented Jul 20, 2017

@liewegas i am adding this PR to luminous, as it will be a pain in future when we will need to backport changes to this file.

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 20, 2017

Member

i am adding this PR to luminous, as it will be a pain in future when we will need to backport changes to this file.

Agree

Member

xiexingguo commented Jul 20, 2017

i am adding this PR to luminous, as it will be a pain in future when we will need to backport changes to this file.

Agree

@tchaikov

This comment has been minimized.

Show comment
Hide comment
Contributor

tchaikov commented Jul 21, 2017

@tchaikov tchaikov merged commit 7318668 into ceph:master Jul 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment