Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: a few health fixes #16415

Merged
merged 4 commits into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Copy link
Member

xiexingguo commented Jul 19, 2017

No description provided.

xiexingguo added some commits Jul 19, 2017

mon/HealthMonitor: fix regex formatting
Was:
./bin/ceph -s
  cluster:
    id:     0f704e51-f496-4812-a782-f6bcc490a109
    health: HEALTH_ERR
            mon%plurals% %names% %isorare% low on available space

Now:
 ./bin/ceph -s
  cluster:
    id:     1bb2cc6d-ba6f-467a-b811-994101a42749
    health: HEALTH_ERR
            mon a is low on available space

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
mon/HealthMonitor: fix wrong health level
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
mon/HealthMonitor: fix mon_warn_on_osd_down_out_interval_zero does no…
…t work

And the output is wrong...

cluster:
    id:     b979e20d-6441-46b4-8663-954e1e8ce01d
    health: HEALTH_WARN
            1 osds down
            mon %names has mon_osd_down_out_interval set to 0

Now:
 health: HEALTH_WARN
            mon a is low on available space
            mon a has mon_osd_down_out_interval set to 0

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo requested a review from liewegas Jul 19, 2017

@xiexingguo xiexingguo added this to the luminous milestone Jul 19, 2017

@liewegas liewegas added the needs-qa label Jul 19, 2017

mon/HealthMonitor: fix summary of monitor clock skew
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Jul 20, 2017

Append one more patch 47cc691 to fix summary of clock skew warn.

@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Jul 20, 2017

retest this please

1 similar comment
@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Jul 20, 2017

retest this please

@tchaikov

This comment has been minimized.

Copy link
Contributor

tchaikov commented Jul 21, 2017

the failed tests are related to health checking and monitor, and they are addressed by #16477. so i don't think they are relevant.

@tchaikov tchaikov merged commit d76b376 into ceph:master Jul 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-health-mon branch Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.