New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rgw clarify limitations when creating tenant names #16418

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
5 participants
@theanalyst
Member

theanalyst commented Jul 19, 2017

We only allow alphanumeric and underscore characters in tenant names
according to the validation in RGWHandler_REST::validate_tenant_name

Signed-off-by: Abhishek Lekshmanan abhishek@suse.com

@amitkumar50

This comment has been minimized.

Contributor

amitkumar50 commented Jul 19, 2017

For which documentation bug, this PR is generated?

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 19, 2017

might be worth a validation in rgw_admin (and possibly a backport) as well

@@ -40,6 +40,8 @@ Create a user testx$tester to be accessed with Swift::
Note that the subuser with explicit tenant had to be quoted in the shell.
.. note:: Tenant names may only contain alphanumeric characters and underscores
Accessing Buckets with Explicit Tenants

This comment has been minimized.

@joscollin

joscollin Jul 20, 2017

Member

@theanalyst Can you make it a single Note ? I think both sentences can be put under a single ..note::, which is better to read and neat display.

Note that the subuser with explicit tenant had to be quoted in the shell.

.. note:: Tenant names may only contain alphanumeric characters and underscores
doc: rgw clarify limitations when creating tenant names
We only allow alphanumeric and underscore characters in tenant names
according to the validation in `RGWHandler_REST::validate_tenant_name`

Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 20, 2017

@joscollin updated

@joscollin

LGTM

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 20, 2017

Jenkins retest this please

@joscollin joscollin merged commit c6e90d9 into ceph:master Jul 20, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment