New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: '* list' -> '* ls' #16423

Merged
merged 3 commits into from Jul 20, 2017

Conversation

Projects
None yet
4 participants
@liewegas
Member

liewegas commented Jul 19, 2017

There are just few legacy commands not following current style.

@theanalyst

This comment has been minimized.

Member

theanalyst commented Jul 19, 2017

PendingReleaseNotes entry

@liewegas liewegas requested a review from tchaikov Jul 19, 2017

@liewegas liewegas added this to the luminous milestone Jul 19, 2017

liewegas added some commits Jul 19, 2017

mon: 'config-key list' -> 'config-key ls'
Signed-off-by: Sage Weil <sage@redhat.com>
mon: 'auth list' -> 'auth ls'
Signed-off-by: Sage Weil <sage@redhat.com>
@liewegas

This comment has been minimized.

Member

liewegas commented Jul 19, 2017

updated release-notes.rst directly

@@ -537,6 +537,7 @@ function test_auth()
ceph auth add client.xx -i client.xx.keyring
rm -f client.xx.keyring
ceph auth list | grep client.xx

This comment has been minimized.

@xiexingguo

xiexingguo Jul 20, 2017

Member

And drop this line?

This comment has been minimized.

@xiexingguo

xiexingguo Jul 20, 2017

Member

Well, I am a little confused. Do you mean we should test both formats?

This comment has been minimized.

@tchaikov

tchaikov Jul 20, 2017

Contributor

we should before "auth list" is dropped.

@tchaikov

aside from the nit, lgtm

@@ -14,6 +14,7 @@ ceph osd crush dump
ceph osd crush rule dump
ceph osd crush rule ls
ceph osd crush rule list
ceph osd crush rule ls

This comment has been minimized.

@tchaikov

@tchaikov tchaikov added the needs-qa label Jul 20, 2017

@@ -575,9 +576,9 @@ function test_auth()
check_response "auid = $auid"
ceph --format json-pretty auth get client.TEST > $TMPFILE
check_response '"auid": '$auid
ceph auth list > $TMPFILE
ceph auth ls > $TMPFILE

This comment has been minimized.

@xiexingguo

xiexingguo Jul 20, 2017

Member

@tchaikov Thanks, kefu. I get confused because Sage directly updates the old format here and below.

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 20, 2017

mon: hide 'osd crush rule list' (we prefer 'ls')
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 3de9f22 into ceph:master Jul 20, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-ls branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment