New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include/assert: test c++ before using static_cast<> #16424

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jul 19, 2017

this partially reverts 2e7c72d.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the bug fix label Jul 19, 2017

@tchaikov tchaikov requested review from liewegas and jdurgin Jul 19, 2017

@liewegas liewegas added this to the luminous milestone Jul 19, 2017

#ifdef __cplusplus
# define __CEPH_ASSERT_VOID_CAST static_cast<void>
#else
# define __CEPH_ASSERT_VOID_CAST (void)

This comment has been minimized.

@cbodley

cbodley Jul 19, 2017

Contributor

nit: identifiers starting with __ are reserved and their use is technically undefined behavior

include/assert: test c++ before using static_cast<>
this partially reverts 2e7c72d.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 19, 2017

@cbodley fixed and repushed.

@tchaikov tchaikov merged commit 37a7035 into ceph:master Jul 20, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-assert-in-c branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment