New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa: Added luminous to the mix in schedule_subset.sh #16430

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
3 participants
@yuriw
Contributor

yuriw commented Jul 19, 2017

Signed-off-by: Yuri Weinstein yweinste@redhat.com

Added luminous to the mix
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

@yuriw yuriw requested a review from jdurgin Jul 19, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 20, 2017

Jenkins retest this please

@tchaikov tchaikov added the tests label Jul 20, 2017

@@ -36,6 +36,9 @@ elif [ $2 = "jewel" ] ; then
elif [ $2 = "kraken" ] ; then
# run kraken branch with /40 jobs
teuthology-suite -v -c $2 -m $3 -k distro -s $4 --subset $(echo "(($(date +%U) % 4) * 7) + $1" | bc)/40 -e $5 $6
elif [ $2 = "luminous" ] ; then
# run luminous branch with /40 jobs
teuthology-suite -v -c $2 -m $3 -k distro -s $4 --subset $(echo "(($(date +%U) % 4) * 7) + $1" | bc)/40 -e $5 $6
else

This comment has been minimized.

@joscollin

joscollin Jul 20, 2017

Member

If luminous, kraken and jewel are executing the same statement inside, why can't it be combined in a single if ? Or is it intended ?

This comment has been minimized.

@tchaikov

tchaikov Jul 20, 2017

Contributor

$2

This comment has been minimized.

@joscollin

joscollin Jul 20, 2017

Member

@tchaikov Ah! got it. Thanks.

@tchaikov tchaikov changed the title from Added luminous to the mix to qa: Added luminous to the mix Jul 20, 2017

@joscollin

LGTM

@joscollin joscollin changed the title from qa: Added luminous to the mix to qa: Added luminous to the mix in schedule_subset.sh Jul 21, 2017

@joscollin joscollin merged commit fae6dc4 into ceph:master Jul 21, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment