New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do_cmake.sh: fix syntax for /bin/sh (doesn't have +=) #16433

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
6 participants
@dmick
Member

dmick commented Jul 19, 2017

Signed-off-by: Dan Mick dan.mick@redhat.com

do_cmake.sh: fix syntax for /bin/sh (doesn't have +=)
Signed-off-by: Dan Mick <dan.mick@redhat.com>

@dmick dmick requested a review from liewegas Jul 19, 2017

@gregsfortytwo

LGTM!

@jcsp

This comment has been minimized.

Contributor

jcsp commented Jul 19, 2017

Saw this in the list of PRs and thought +=) was a new emoji

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 19, 2017

thought +=) was a new emoji

🤣

@dmick

This comment has been minimized.

Member

dmick commented Jul 20, 2017

Yes, that's the "Charles Manson grinning"

@joscollin joscollin added the bug fix label Jul 20, 2017

@tchaikov tchaikov merged commit c483e8b into ceph:master Jul 20, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment