New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw_file: properly & |'d flags #16448

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
4 participants
@mattbenjamin
Contributor

mattbenjamin commented Jul 20, 2017

Found by "Supriti Singh" Supriti.Singh@suse.com.

Fixes http://tracker.ceph.com/issues/20663

Signed-off-by: Matt Benjamin mbenjamin@redhat.com

rgw_file: properly & |'d flags
Found by "Supriti Singh" <Supriti.Singh@suse.com>.

Fixes http://tracker.ceph.com/issues/20663

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

@mattbenjamin mattbenjamin added rgw and removed common labels Jul 20, 2017

@mattbenjamin

This comment has been minimized.

Contributor

mattbenjamin commented Jul 20, 2017

@joscollin to the best of my knowledge, this package is only used in RGW for the moment, thanks for adding the tags, though!

@mattbenjamin mattbenjamin self-assigned this Jul 20, 2017

@cbodley cbodley merged commit 6929f21 into ceph:master Jul 21, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@yehudasa

This comment has been minimized.

Member

yehudasa commented Sep 12, 2017

@mattbenjamin the train has already left the station long ago, but instead of two checks you could instead of ((flags & FLAG_LOCK) && (flags & FLAG_UNLOCK)) do ((flags & FLAG_LOCK| FLAG_UNLOCK) == (FLAG_LOCK | FLAG_UNLOCK)).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment