New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/reg11184: use literal 'foo' instead pool_name #16451

Merged
merged 1 commit into from Jul 20, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jul 20, 2017

partially reverts 836ab7a.

  • pool_name not defined here
  • this test is not relevant to this test case

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov requested review from dzafman and dillaman Jul 20, 2017

@tchaikov

This comment has been minimized.

@tchaikov tchaikov added this to the luminous milestone Jul 20, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jul 20, 2017

@tchaikov Not sure how that happened -- I had fixed that to hard-code "foo" but I must have overwritten it w/ a later force-push. That command is required otherwise it fails the test due to health warnings.

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jul 20, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 20, 2017

@dillaman copy that! fixed and repushed.

qa/tasks/reg11184: use literal 'foo' instead pool_name
Signed-off-by: Kefu Chai <kchai@redhat.com>
@dillaman

lgtm -- thx!

@dillaman dillaman changed the title from qa/tasks/reg11184: do not set application metadata to qa/tasks/reg11184: use literal 'foo' instead pool_name Jul 20, 2017

@dillaman dillaman merged commit b47eb21 into ceph:master Jul 20, 2017

2 of 4 checks passed

make check running make check
Details
make check (arm64) Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@tchaikov tchaikov deleted the tchaikov:wip-qa-reg11184 branch Jul 20, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment