Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crush: enforce buckets-before-rules rule #16453

Merged
merged 2 commits into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

liewegas commented Jul 20, 2017

...and remove the mon workloadgen test. The test seems pretty broken and i'm not sure it's worth the effort needed to fix?

liewegas added some commits Jul 20, 2017

crush/CrushCompiler: enforce buckets before rules rule
Signed-off-by: Sage Weil <sage@redhat.com>
qa: remove workloadgen test
The CRUSH rule creation is busted (rules and buckets out of order), but
after I fix that it doesn't seem to run right anyway.  Remove it.
We get the mon thrasher coverage from rados/monthrash already; I don't
think this is adding meaningful coverage for the amount of effort it takes
to maintain.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-workloadgen branch from 68e44ae to 2e8413d Jul 20, 2017

@liewegas liewegas changed the title qa/workunits/mon/workloadgen: avoid colliding rule ids crush: enforce buckets-before-rules rule Jul 21, 2017

@liewegas liewegas requested a review from jecluis Jul 21, 2017

@liewegas liewegas added this to the luminous milestone Jul 21, 2017

@jecluis
Copy link
Member

jecluis left a comment

this looks good to me. I'm not familiar enough with crush code (sigh) to validate its correctness, but the idea seems sound and I have no objections to the code itself.

@liewegas liewegas merged commit cb084a5 into ceph:master Jul 21, 2017

2 of 4 checks passed

make check make check failed
Details
make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-workloadgen branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.