New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd,mds,mgr: do not dereference null rotating_keys #16455

Merged
merged 3 commits into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jul 20, 2017

Immediately after we bind to a port, but before we have set up our
auth infrastructure, we may get incoming connections. Deny them. Since
we are not yet advertising ourselves these are peers trying to connect
to old instances of daemons, not us.

This triggers now because of bf49385.
Previously, the peer would see we were a different addr and drop the
connection. Now, it continues.

Fixes: http://tracker.ceph.com/issues/20667
Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added this to the luminous milestone Jul 20, 2017

liewegas added some commits Jul 20, 2017

osd,mds,mgr: do not dereference null rotating_keys
Immediately after we bind to a port, but before we have set up our
auth infrastructure, we may get incoming connections.  Deny them.  Since
we are not yet advertising ourselves these are peers trying to connect
to old instances of daemons, not us.

This triggers now because of bf49385.
Previously, the peer would see we were a different addr and drop the
connection.  Now, it continues.

Fixes: http://tracker.ceph.com/issues/20667
Signed-off-by: Sage Weil <sage@redhat.com>
msg: restore peer addr checks
This was dropped in bf49385 but should
not have been.  Since we are advertising the addr and not the bind
addr there is no reason to disable this check.

Signed-off-by: Sage Weil <sage@redhat.com>
@bassam

bassam approved these changes Jul 20, 2017

@liewegas liewegas added the needs-qa label Jul 20, 2017

osd: bail out if no map yet
If we get pings before finishing our startup we may not yet have an
osdmap.

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 33daf6f into ceph:master Jul 21, 2017

2 of 4 checks passed

make check make check failed
Details
make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@liewegas liewegas deleted the liewegas:wip-20667 branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment