New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: fix a couple bugs with persisting the missing set when it contains deletes #16459

Merged
merged 2 commits into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@jdurgin
Member

jdurgin commented Jul 20, 2017

No description provided.

jdurgin added some commits Jul 20, 2017

ceph_objectstore_tool: always write may_include_deletes if it's set
This prevents us from importing a missing set without also setting the
may_include_deletes_in_missing omap value if appropriate.

Signed-off-by: Josh Durgin <jdurgin@redhat.com>
osd/PGLog: force write of may_include_deletes after split
When a collection is split this needs to be persisted again. Normally
this is only persisted when the missing set is rebuilt during a new
interval when it previous did not include deletes, but during split we
keep the in-memory missing set may_include_deletes flag, but do not
rebuild the missing set.

Fixes: http://tracker.ceph.com/issues/20704
Signed-off-by: Josh Durgin <jdurgin@redhat.com>

@jdurgin jdurgin added this to the luminous milestone Jul 20, 2017

@jdurgin jdurgin requested a review from liewegas Jul 20, 2017

@liewegas liewegas merged commit 9bd678e into ceph:master Jul 21, 2017

2 of 4 checks passed

make check make check failed
Details
make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@jdurgin jdurgin deleted the jdurgin:wip-20704 branch Jul 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment