New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/PGMap: remove skewed utilizatoin warning #16461

Merged
merged 1 commit into from Jul 21, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jul 20, 2017

This has a few problems:

1- It does not do it's analysis over CRUSH rule roots/classes, which
means that an innocent user of classes will see skewed usage (bc hdds are
more full than ssds, say)

2- It does not take degraded clusters into account, which means the warning
will appear when a fresh OSD is added.

See http://tracker.ceph.com/issues/20730

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas added this to the luminous milestone Jul 20, 2017

@liewegas liewegas added the mon label Jul 20, 2017

@liewegas liewegas requested a review from jcsp Jul 20, 2017

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 21, 2017

pity we have finally to give up this...

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 21, 2017

does not compile

/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/PGMap.cc: In member function ‘void PGMap::get_health(CephContext*, const OSDMap&, std::list<std::pair<health_status_t, std::basic_string<char> > >&, std::list<std::pair<health_status_t, std::basic_string<char> > >*) const’:

/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/PGMap.cc:3412:19: error: ‘struct md_config_t’ has no member named ‘mon_warn_osd_usage_min_max_delta’
   if (cct->_conf->mon_warn_osd_usage_min_max_delta) {
                   ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/PGMap.cc:3425:28: error: ‘struct md_config_t’ has no member named ‘mon_warn_osd_usage_min_max_delta’
     if (diff > cct->_conf->mon_warn_osd_usage_min_max_delta) {
                            ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/mon/PGMap.cc:3430:25: error: ‘struct md_config_t’ has no member named ‘mon_warn_osd_usage_min_max_delta’
   << roundf(cct->_conf->mon_warn_osd_usage_min_max_delta*1000.0)/10.0
mon/PGMap: remove skewed utilizatoin warning
This has a few problems:

1- It does not do it's analysis over CRUSH rule roots/classes, which
means that an innocent user of classes will see skewed usage (bc hdds are
more full than ssds, say)

2- It does not take degraded clusters into account, which means the warning
will appear when a fresh OSD is added.

See http://tracker.ceph.com/issues/20730

Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 29996ea into ceph:master Jul 21, 2017

0 of 4 checks passed

Signed-off-by checking if commits are signed
Details
Unmodified Submodules checking if PR has modified submodules
Details
make check running make check
Details
make check (arm64) Build triggered. sha1 is merged.
Details

@liewegas liewegas deleted the liewegas:wip-skewed branch Jul 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment