New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix parse/eval of policy conditions with IfExists #16463

Merged
merged 2 commits into from Jul 27, 2017

Conversation

Projects
None yet
4 participants
@cbodley
Contributor

cbodley commented Jul 20, 2017

Fixes: http://tracker.ceph.com/issues/20708

Makes progress in passing test_bucket_policy_set_condition_operator_end_with_IfExists from ceph/s3-tests#167, but we still need wildcard support from #15702

@cbodley cbodley requested a review from adamemerson Jul 20, 2017

rgw: policy can parse IfExists conditions
when ParseState::key() encounters a condition statement ending with
IfExists, it looks up the token by its prefix only

because this prefix is not null-terminated, the gperf-generated
comparison has to be modified to use strncmp() instead of strcmp() by
adding the %compare-strncmp flag to the gperf file

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@adamemerson

Very nicely done.

Lemurs Graft Trees Meticulously

@cbodley cbodley added the needs-qa label Jul 21, 2017

rgw: consider IfExists when evaluating policy conditions
Fixes: http://tracker.ceph.com/issues/20708

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@ceph-jenkins

This comment has been minimized.

Collaborator

ceph-jenkins commented Jul 21, 2017

submodules for project are unmodified

@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 24, 2017

jenkins test this please

1 similar comment
@cbodley

This comment has been minimized.

Contributor

cbodley commented Jul 26, 2017

jenkins test this please

@yuriw yuriw merged commit 63a5f60 into ceph:master Jul 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@cbodley cbodley deleted the cbodley:wip-20708 branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment