Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon: stop issuing not-[deep]-scrubbed warnings if disabled #16465

Merged
merged 3 commits into from Jul 22, 2017

Conversation

Projects
None yet
2 participants
@xiexingguo
Copy link
Member

xiexingguo commented Jul 21, 2017

No description provided.

mon/PGMap: fix unable to shut up pg-not-scrubbed[deep-scrubbed] warn
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo requested a review from liewegas Jul 21, 2017

"degraded|inconsistent|peering|repair|recovering|backfill_wait|" \
"incomplete|stale|remapped|deep_scrub|backfill|backfill_toofull|" \
"recovery_wait|undersized|activating|peered|recovery_toofull|" \
"snaptrim|snaptrim_wait|snaptrim_error,n=N,req=false ", \

This comment has been minimized.

Copy link
@liewegas

liewegas Jul 21, 2017

Member

I was just thinking about this today. It might be simpler to just make this CephStrings and drop the validation on the client side. The mon will parse the state and issue an error if it's not a known pg state anyway... easier to maintain that way.

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jul 21, 2017

The other two commits look good!

@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Jul 21, 2017

I was just thinking about this today. It might be simpler to just make this CephStrings and drop the validation on the client side. The mon will parse the state and issue an error if it's not a known pg state anyway... easier to maintain that way

Yeah, that is what I am initially going to do

@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jul 21, 2017

sounds like a plan! :)

mgr: drop unnecessary write permission for test-reweight-by-* commands
dry run does not ask for it

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo force-pushed the xiexingguo:wip-shutup-noscrub-warn branch 2 times, most recently from 741971d to 9d7ce34 Jul 21, 2017

@xiexingguo

This comment has been minimized.

Copy link
Member Author

xiexingguo commented Jul 21, 2017

retest this please

@xiexingguo xiexingguo force-pushed the xiexingguo:wip-shutup-noscrub-warn branch from 9d7ce34 to a495184 Jul 21, 2017

mon/PGMap: drop client-side pg states validations
let mon do this instead...

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>

@xiexingguo xiexingguo added the needs-qa label Jul 21, 2017

@xiexingguo xiexingguo added this to the luminous milestone Jul 21, 2017

@liewegas liewegas merged commit 165f80a into ceph:master Jul 22, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-shutup-noscrub-warn branch Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.