New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: show rbd image features #16468

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
4 participants
@gmayyyha
Contributor

gmayyyha commented Jul 21, 2017

[root@ceph14 build]# rbd map disk01
rbd: sysfs write failed
RBD image feature set mismatch. Try disabling features unsupported by the kernel with "rbd feature disable".
In some cases useful info is found in syslog - try "dmesg | tail".
rbd: map failed: (6) No such device or address

mgr-rbd-images-show

we can see the RBD images features, disabling features unsupported by the kernel

Signed-off-by: Yanhu Cao gmayyyha@gmail.com

@tchaikov tchaikov requested review from jcsp and dillaman Jul 21, 2017

count = 0
names = ""
features_dict = {
1<<0: "layering",

This comment has been minimized.

@dillaman

dillaman Jul 21, 2017

Contributor

Nit: prefer for you to use the defined constants from here [1]

[1] https://github.com/ceph/ceph/blob/master/src/pybind/rbd/rbd.pyx#L342

if (key & features == 0):
continue
if count > 0:

This comment has been minimized.

@dillaman

dillaman Jul 21, 2017

Contributor

Nit: if name: and then eliminate the need for count

This comment has been minimized.

@gmayyyha

gmayyyha Jul 24, 2017

Contributor

@dillaman thanks for your advice. already done.

@dillaman dillaman changed the title from mgr: rbd image show features to mgr/dashboard: show rbd image features Jul 21, 2017

@dillaman dillaman added mgr rbd labels Jul 21, 2017

@jcsp

jcsp approved these changes Jul 24, 2017

@jcsp jcsp referenced this pull request Jul 24, 2017

Merged

mgr/dashboard: rbd mirroring status page #16360

2 of 2 tasks complete
@jcsp

This comment has been minimized.

Contributor

jcsp commented Jul 24, 2017

@gmayyyha could you rebase this please? We just merged another change to the rbd markup

mgr/dashboard: rbd image show features
Signed-off-by: Yanhu Cao <gmayyyha@gmail.com>
@gmayyyha

This comment has been minimized.

Contributor

gmayyyha commented Jul 25, 2017

@jcsp done.

@dillaman dillaman merged commit 62b6d2d into ceph:master Jul 25, 2017

2 of 4 checks passed

make check running make check
Details
make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details

@gmayyyha gmayyyha deleted the gmayyyha:mgr-show-rbd-features branch Jul 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment