New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: s/osd_objectstore_type/osd_objectstore #16469

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@xiexingguo
Member

xiexingguo commented Jul 21, 2017

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

@xiexingguo xiexingguo requested review from tchaikov and liewegas Jul 21, 2017

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 21, 2017

retest this please

@@ -1678,7 +1678,7 @@ function test_mon_osd_pool()
ceph osd pool create ec_test 1 1 erasure
ceph osd pool application enable ec_test rados
set +e
ceph osd metadata | grep osd_objectstore_type | grep -qc bluestore
ceph osd metadata | grep osd_objectstore | grep -qc bluestore

This comment has been minimized.

@tchaikov

tchaikov Jul 21, 2017

Contributor

better off switching to jq.

@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 22, 2017

switch to "ceph osd count-metadata", now the output is simple enough and let's not bother using jq here.

@xiexingguo xiexingguo added the needs-qa label Jul 22, 2017

@xiexingguo xiexingguo added this to the luminous milestone Jul 22, 2017

test: s/osd_objectstore_type/osd_objectstore/
Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 22, 2017

seems the original test-case is broken and never functionable, repushed

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 24, 2017

cephtool is failing for other reasons, not merging this just yet.

@liewegas liewegas merged commit d2c31a8 into ceph:master Jul 26, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@xiexingguo xiexingguo deleted the xiexingguo:wip-fix-test branch Feb 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment