New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: reword mds deactivate docs; add optional fs_name argument #16471

Merged
merged 1 commit into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@jan--f
Member

jan--f commented Jul 21, 2017

Fixes: http://tracker.ceph.com/issues/20607

Signed-off-by: Jan Fajerski jfajerski@suse.com

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 21, 2017

Jenkins retest this please

@@ -94,12 +94,13 @@ available, then the "failed" daemon will return as a standby.
::
mds deactivate <role>
mds deactivate [<fs_name>:]<rank>

This comment has been minimized.

@batrick

batrick Jul 21, 2017

Member

The role argument can actually be other forms too;

https://github.com/jan--f/ceph/blob/2155f7fef6415ac0cca88e1eb5a7b12c995f3433/src/mds/FSMap.cc#L970-L982

I'd prefer leaving it as role and link to a doc explaining what a role's form can be.

Deactivating a rank causes the MDS daemon servicing this rank to flush its
entire journal to the backing RADOS objects and close all open client
sessions. Deactivating a rank is primarily intended to have an MDS daemon
rejoin the cluster as a standby after reducing the number of active MDS

This comment has been minimized.

@batrick

batrick Jul 21, 2017

Member

The previous wording is correct. The actual intent is to shrink the number of active ranks. You can add that the MDS will rejoin as a standby after deactivating the rank.

@@ -81,7 +81,7 @@ Note that we still have two active MDSs: the ranks still exist even though
we have decreased max_mds, because max_mds only restricts creation
of new ranks.
Next, use the ``ceph mds deactivate <rank>`` command to remove the
Next, use the ``ceph mds deactivate <fs_name>:<rank>`` command to remove the

This comment has been minimized.

@batrick

batrick Jul 21, 2017

Member

Use <role>.

doc: extend mds deactivate docs
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
@jan--f

This comment has been minimized.

Member

jan--f commented Jul 21, 2017

@batrick Thank you for clarifying!

@tchaikov tchaikov merged commit 5c374e7 into ceph:master Aug 1, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@batrick batrick added the cephfs label Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment