New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mon/HealthMonitor: trigger a proposal if stat updated #16477

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
None yet
3 participants
@tchaikov
Contributor

tchaikov commented Jul 21, 2017

leader should always propose if the peon update it with new health stats

Signed-off-by: Kefu Chai kchai@redhat.com

return false;
}
bool HealthMonitor::prepare_update(MonOpRequestRef op)

This comment has been minimized.

@tchaikov

tchaikov Jul 21, 2017

Contributor

seems we took prepare_update() for preprocess_query().

mon/HealthMonitor: trigger a proposal if stat updated
leader should always propose if the peon update it with new health stats

Signed-off-by: Kefu Chai <kchai@redhat.com>
@xiexingguo

This comment has been minimized.

Member

xiexingguo commented Jul 21, 2017

Thanks for fixing this, kefu.(I also find another kind of cure but yours seems far more elegant).

I post #16478 to fix another potential problem(without this, peon would keep sending empty health_check messages), can you help to confirm?

@tchaikov tchaikov added the needs-qa label Jul 21, 2017

@liewegas liewegas merged commit 31e9061 into ceph:master Jul 22, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-health-mon branch Jul 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment