New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: remove config opt conversion utility #16480

Merged
merged 1 commit into from Jul 22, 2017

Conversation

Projects
None yet
3 participants
@jcsp
Contributor

jcsp commented Jul 21, 2017

Now that the new options.cc stuff has landed, this is no longer
needed.

Signed-off-by: John Spray john.spray@redhat.com

John Spray
common: remove config opt conversion utility
Now that the new options.cc stuff has landed, this is no longer
needed.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp added cleanup core labels Jul 21, 2017

@jcsp jcsp added this to the luminous milestone Jul 21, 2017

@jcsp jcsp requested a review from idryomov Jul 21, 2017

@idryomov

LGTM

@idryomov

This comment has been minimized.

Contributor

idryomov commented Jul 21, 2017

retest this please

@idryomov

This comment has been minimized.

Contributor

idryomov commented Jul 21, 2017

retest this please

@liewegas liewegas merged commit bea20a4 into ceph:master Jul 22, 2017

2 of 4 checks passed

make check make check failed
Details
Unmodified Submodules checking if PR has modified submodules
Details
Signed-off-by all commits in this PR are signed
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment