New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/options: refactors to set the properties in a more structured way #16482

Merged
merged 2 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Contributor

tchaikov commented Jul 21, 2017

No description provided.

@tchaikov tchaikov changed the title from common to common/options: refactors to reduce memory foot print Jul 21, 2017

@tchaikov tchaikov requested a review from jcsp Jul 21, 2017

@tchaikov tchaikov changed the title from common/options: refactors to reduce memory foot print to common/options: refactors to set the properties in a more structured way Jul 21, 2017

@tchaikov

This comment has been minimized.

Contributor

tchaikov commented Jul 21, 2017

retest this please

@jcsp

This comment has been minimized.

Contributor

jcsp commented Jul 24, 2017

Hmm, generally I wouldn't care about such a small memory overhead, but I guess since we embed one of these objects in our clients, it is worthwhile.

@jcsp

jcsp approved these changes Jul 24, 2017

@tchaikov tchaikov added the needs-qa label Jul 24, 2017

tchaikov added some commits Jul 21, 2017

common/config: accept initialize_list when adding option properties
it's syntax sugar, but more handly this way. and it helps to reduce
memory foot print.

Signed-off-by: Kefu Chai <kchai@redhat.com>
common/config: change the element type of lists to "const char*"
there lists holds constant string literals. and they are not changeable
at runtime. so make std::list<const char*> for smaller memory foot
print.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov merged commit 9167486 into ceph:master Jul 28, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-opt branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment