New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use CMAKE_INSTALL_INCLUDEDIR #16483

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@ddiss
Contributor

ddiss commented Jul 21, 2017

Header files are currently installed under a hardcoded "include" path.
Use CMAKE_INSTALL_INCLUDEDIR instead, which defaults to "include" but
allows for customisation alongside other (already used) CMAKE_INSTALL_X
paths.

Signed-off-by: David Disseldorp ddiss@suse.de

cmake: use CMAKE_INSTALL_INCLUDEDIR
Header files are currently installed under a hardcoded "include" path.
Use CMAKE_INSTALL_INCLUDEDIR instead, which defaults to "include" but
allows for customisation alongside other (already used) CMAKE_INSTALL_X
paths.

Signed-off-by: David Disseldorp <ddiss@suse.de>
@ddiss

This comment has been minimized.

Contributor

ddiss commented Jul 21, 2017

FWIW, my motivation for this change is so that I can build Samba (configured with --enable-cephfs --with-libcephfs=X) alongside a Ceph source repository which has been built and installed to a custom path.

@cbodley cbodley added the build/ops label Jul 21, 2017

@cbodley cbodley added the needs-qa label Jul 21, 2017

@tchaikov

lgtm also

@tchaikov tchaikov merged commit 344ed5f into ceph:master Jul 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment