New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/options.cc: document bluestore config options #16489

Merged
merged 4 commits into from Jul 28, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Member

liewegas commented Jul 21, 2017

Signed-off-by: Sage Weil sage@redhat.com

@liewegas liewegas requested a review from markhpc Jul 21, 2017

@liewegas liewegas added this to the luminous milestone Jul 21, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 21, 2017

@jdurgin @jcsp now is probably the time to write some guidelines about how tags, service, and so on should be used.

@markhpc

This comment has been minimized.

Member

markhpc commented Jul 24, 2017

I'll try to look over these today

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 26, 2017

@markhpc ping

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 26, 2017

retest this please

liewegas added some commits Jul 21, 2017

doc/dev/config: some guidance around defining config options
Signed-off-by: Sage Weil <sage@redhat.com>
os/bluestore: observe bluestore_compression_required_ratio
Signed-off-by: Sage Weil <sage@redhat.com>
compressor: accept 'none' or '' for none
This makes the parse and output methods match up.

Signed-off-by: Sage Weil <sage@redhat.com>
common/options: document bluestore options
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas merged commit 6f0f376 into ceph:master Jul 28, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-bluestore-options branch Jul 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment