New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix radosgw will crash when service is restarted during lifecycl… #16495

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
7 participants
@weiqiaomiao
Contributor

weiqiaomiao commented Jul 22, 2017

…e processing

in RGWRados::finalize(), store->gc is destructed before store->lc, if this func is called
(by service restart or others) when lifecycle processing, the lifecycle still use store->gc,
the radosgw daemon will crash.

Signed-off-by: Wei Qiaomiao wei.qiaomiao@zte.com.cn

@joscollin joscollin self-requested a review Jul 22, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 22, 2017

Jenkins retest this please

@joscollin

LGTM. I hope you have tested the fix.

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 22, 2017

Jenkins retest this please

1 similar comment
@joscollin

This comment has been minimized.

Member

joscollin commented Jul 24, 2017

Jenkins retest this please

@joscollin joscollin added the needs-qa label Jul 24, 2017

@oritwas

This comment has been minimized.

Contributor

oritwas commented Jul 24, 2017

@weiqiaomiao, can you open a tracker issue so we can backport this?
Add to the commit comment:
Fixes: url to the tracker issue

rgw: fix radosgw will crash when service is restarted during lifecycl…
…e processing

in RGWRados::finalize(), store->gc is destructed before store->lc, if this func is called
(by service restart or others) when lifecycle processing, the lifecycle still use store->gc,
the radosgw daemon will crash.

Fixes: http://tracker.ceph.com/issues/20756
Signed-off-by: Wei Qiaomiao <wei.qiaomiao@zte.com.cn>
@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jul 24, 2017

@oritwas updated. Thanks!

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 24, 2017

@weiqiaomiao Updated the tracker.

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 25, 2017

Jenkins retest this please

@benh57

This comment has been minimized.

benh57 commented Jul 25, 2017

@dang

dang approved these changes Jul 25, 2017

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jul 26, 2017

Jenkins retest this please

@yuriw yuriw merged commit 8ff76b7 into ceph:master Jul 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment