New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: Drop dump_usage_bucket_info() to silence warning from -Wunused-function #16497

Merged
merged 1 commit into from Jul 25, 2017

Conversation

Projects
None yet
2 participants
@weiqiaomiao
Contributor

weiqiaomiao commented Jul 22, 2017

Fix compile warning in any PR (Ex: https://jenkins.ceph.com/job/ceph-pull-requests/29193/console):

/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_usage.cc:33:13: warning: ‘void dump_usage_bucket_info(ceph::Formatter*, std::__cxx11::string&, cls_user_bucket_entry&)’ defined but not used [-Wunused-function]
 static void dump_usage_bucket_info(Formatter *formatter, string& name, cls_user_bucket_entry& entry)

Signed-off-by: Wei Qiaomiao wei.qiaomiao@zte.com.cn

@joscollin joscollin self-requested a review Jul 22, 2017

@joscollin

LGTM.

If you are getting a warning, please post the output text and specify the gcc version here. Otherwise, change the title to "Drop Unused function in rgw_usage.cc".

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jul 22, 2017

@joscollin OK. Thanks!

@weiqiaomiao weiqiaomiao changed the title from rgw: fix compile warning from -Wunused-function to rgw: Drop Unused function in rgw_usage.cc Jul 22, 2017

@joscollin joscollin changed the title from rgw: Drop Unused function in rgw_usage.cc to rgw: Drop dump_usage_bucket_info() to silence warning from -Wunused-function Jul 22, 2017

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 24, 2017

Jenkins retest this please

rgw: Drop Unused function in rgw_usage.cc
fix compile warnning in any PR (Ex: https://jenkins.ceph.com/job/ceph-pull-requests/29193/console):
/home/jenkins-build/build/workspace/ceph-pull-requests/src/rgw/rgw_usage.cc:33:13: warning: ‘void dump_usage_bucket_info(ceph::Formatter*, std::__cxx11::string&, cls_user_bucket_entry&)’ defined but not used [-Wunused-function]
 static void dump_usage_bucket_info(Formatter *formatter, string& name, cls_user_bucket_entry& entry)

Signed-off-by: Wei Qiaomiao <wei.qiaomiao@zte.com.cn>
@joscollin

This comment has been minimized.

Member

joscollin commented Jul 24, 2017

Jenkins retest this please

2 similar comments
@joscollin

This comment has been minimized.

Member

joscollin commented Jul 25, 2017

Jenkins retest this please

@weiqiaomiao

This comment has been minimized.

Contributor

weiqiaomiao commented Jul 25, 2017

Jenkins retest this please

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 25, 2017

@weiqiaomiao I don't know why this fails. Let's try one more time.

@joscollin

This comment has been minimized.

Member

joscollin commented Jul 25, 2017

Jenkins retest this please

@joscollin

LGTM. The warning doesn't appear anymore:

https://jenkins.ceph.com/job/ceph-pull-requests/29428/console

@joscollin joscollin merged commit 0988a34 into ceph:master Jul 25, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment