New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add rbd new trash cli and cleanups in release-notes.rst #16498

Merged
merged 3 commits into from Jul 26, 2017

Conversation

Projects
None yet
5 participants
@Songweibin
Contributor

Songweibin commented Jul 22, 2017

http://tracker.ceph.com/issues/20702
Add rbd trash commands.

Signed-off-by: songweibin song.weibin@zte.com.cn

@Songweibin Songweibin changed the title from [WIP] doc: add rbd trash cli to doc: add rbd new trash commands (cli) Jul 22, 2017

@@ -129,7 +129,7 @@ Major Changes from Kraken
* Improved discard handling when the object map feature is enabled.
* rbd CLI ``import`` and ``copy`` commands now detect sparse and
preserve sparse regions.
* Images and Snapshots will now include a creation timestamp
* Images and Snapshots will now include a creation timestamp.

This comment has been minimized.

@tchaikov

tchaikov Jul 22, 2017

Contributor

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes

This comment has been minimized.

@Songweibin

Songweibin Jul 22, 2017

Contributor

done, thanks.

@Songweibin Songweibin changed the title from doc: add rbd new trash commands (cli) to doc: add rbd new trash cli and cleanup some punctuations in release-notes.rst Jul 22, 2017

doc: add rbd new trash cli in rbd.rst
Signed-off-by: songweibin <song.weibin@zte.com.cn>

@Songweibin Songweibin changed the title from doc: add rbd new trash cli and cleanup some punctuations in release-notes.rst to doc: add rbd new trash cli and cleanups in release-notes.rst Jul 22, 2017

@scienceluo

This comment has been minimized.

Contributor

scienceluo commented Jul 22, 2017

According to the organizationmap , Please update your Signed-off-by info to:

Signed-off-by: Song Weibin song.weibin@zte.com.cn

@dillaman dillaman added this to the luminous milestone Jul 25, 2017

@dillaman

This comment has been minimized.

Contributor

dillaman commented Jul 26, 2017

@Songweibin can you add the doc: prefix to all your commit subjects?

Songweibin added some commits Jul 22, 2017

doc: cleanups in release-notes.rst
Signed-off-by: songweibin <song.weibin@zte.com.cn>
doc: add new trash cli in rados-rbd-cmds.rst
Signed-off-by: songweibin <song.weibin@zte.com.cn>
@Songweibin

This comment has been minimized.

Contributor

Songweibin commented Jul 26, 2017

@dillaman done, thanks.

@liewegas liewegas merged commit f0b5900 into ceph:master Jul 26, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@Songweibin Songweibin deleted the Songweibin:wip-doc-rbd-trash-cli branch Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment