New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: the latency dumped by "ceph osd perf" is not real #16512

Merged
merged 1 commit into from Jul 24, 2017

Conversation

Projects
None yet
2 participants
@liupan1111
Contributor

liupan1111 commented Jul 23, 2017

"ceph osd perf" is used to monitor the real time commit latency and apply latency.

When there is no IO for the cluster(or an OSD), the latency should be zero for "ceph osd perf" command, instead of old value.

Fixes: http://tracker.ceph.com/issues/20749

int32_t ondisk_format = 0; ///< value detected on mount
int _upgrade_super(); ///< upgrade (called during open_super)
void _prepare_ondisk_format_super(KeyValueDB::Transaction& t);

This comment has been minimized.

@liewegas

liewegas Jul 23, 2017

Member

this file shouldn't be added!

This comment has been minimized.

@liupan1111

liupan1111 Jul 23, 2017

Contributor

yes...sorry

if (cur.first == last.first)
return 0;
return (cur.second - last.second) / (cur.first - last.first);
}

This comment has been minimized.

@liewegas

liewegas Jul 23, 2017

Member

These call sites appear to be the only users of the avg() method.. let's just change that? the 'report avg over all time' doesn't make much sense anyway!

This comment has been minimized.

@liupan1111

liupan1111 Jul 23, 2017

Contributor

do you mean we just change the implementation and function name of avg()? for example, rename avg() to real_time(), and implement it as my new change?

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jul 23, 2017

@liewegas updated, thanks.

@liewegas liewegas added the needs-qa label Jul 23, 2017

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 23, 2017

I'd maybe leave it as avg(), or maybe current_avg()?

@liewegas liewegas added this to the luminous milestone Jul 23, 2017

@liupan1111

This comment has been minimized.

Contributor

liupan1111 commented Jul 23, 2017

@liewegas I prefer current_avg(), let me change.

common: the latency dumped by "ceph osd perf" is not real
Signed-off-by: Pan Liu <wanjun.lp@alibaba-inc.com>

@liewegas liewegas merged commit c8e16de into ceph:master Jul 24, 2017

3 of 4 checks passed

make check (arm64) make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@liupan1111 liupan1111 deleted the liupan1111:wip-fix-latency branch Jul 24, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment