New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph: wait for mgr to activate and pg stats to flush in health() #16514

Merged
merged 4 commits into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@liewegas
Member

liewegas commented Jul 23, 2017

Previously, healthy() would just wait for HEALTH_OK. This used to be fine because we
would have non-OK health before the mgr was up. Nowadays we avoid that, which means we need
to explicitly ensure it's up. We flush pg stats as well for good measure so that tests with
implicit dependency on PG state will work.

Fixes: http://tracker.ceph.com/issues/20744

@liewegas liewegas added this to the luminous milestone Jul 23, 2017

@@ -7,3 +7,6 @@ overrides:
tasks:
- install:
- ceph:
# make sure mgr is up by flushing all pg stats
- ceph_manager.flush_all_pg_stats:

This comment has been minimized.

@jcsp

jcsp Jul 24, 2017

Contributor

How come this is needed here? wait-for-healthy is true (I think?) so it would have happened during the ceph task's init

This comment has been minimized.

@liewegas

liewegas Jul 24, 2017

Member

this can go away with the ceph.py patches that follow. the old code only checked HEALTH_OK which didn't make us wait for the mgr to become available.

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 27, 2017

/a/sage-2017-07-26_19:43:32-rados-wip-sage-testing2-distro-basic-smithi/1448268

wait for up osds should ignore ones created by the test

liewegas added some commits Jul 22, 2017

qa/tasks/ceph_manager: expose flush_all_pg_stats
Signed-off-by: Sage Weil <sage@redhat.com>
qa/tasks/ceph_manager: wait_for_all_up -> wait_for_all_osds_up
Signed-off-by: Sage Weil <sage@redhat.com>
qa/tasks/ceph: wait for pg stats to flush in healthy check
Signed-off-by: Sage Weil <sage@redhat.com>
qa/suites/rados/upgrade: fix upgrade wait for healthy
There is no mgr, so we can't call ceph.healthy.

Signed-off-by: Sage Weil <sage@redhat.com>
@jcsp

jcsp approved these changes Jul 27, 2017

@liewegas liewegas merged commit 862392f into ceph:master Jul 27, 2017

4 of 5 checks passed

ceph-volume tox testing Build triggered. sha1 is merged.
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-20744 branch Jul 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment