New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

os/bluestore/BlueStore: remove unused code. #16522

Merged
merged 1 commit into from Jul 26, 2017

Conversation

Projects
None yet
4 participants
@majianpeng
Member

majianpeng commented Jul 24, 2017

Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com

@xiexingguo

This comment has been minimized.

Show comment
Hide comment
@xiexingguo

xiexingguo Jul 24, 2017

Member

Actually we can totally drop this dead first_collection member, which is introduced for cache trimming. As we have already moved that into the MempoolThread now.

Member

xiexingguo commented Jul 24, 2017

Actually we can totally drop this dead first_collection member, which is introduced for cache trimming. As we have already moved that into the MempoolThread now.

@joscollin

Could you please address the above comment ?

@majianpeng

This comment has been minimized.

Show comment
Hide comment
@majianpeng

majianpeng Jul 25, 2017

Member

Ok, i'll do by your suggestions.

Member

majianpeng commented Jul 25, 2017

Ok, i'll do by your suggestions.

@majianpeng

This comment has been minimized.

Show comment
Hide comment
@majianpeng

majianpeng Jul 25, 2017

Member

update.

Member

majianpeng commented Jul 25, 2017

update.

os/bluestore/BlueStore: remove unused code.
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>

@xiexingguo xiexingguo added the needs-qa label Jul 26, 2017

@xiexingguo xiexingguo added this to the luminous milestone Jul 26, 2017

@joscollin

This comment has been minimized.

Show comment
Hide comment
@joscollin

joscollin Jul 26, 2017

Member

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/osd-dup.sh:45: TEST_filestore_to_bluestore: return 1

I think try again and see the result.

Member

joscollin commented Jul 26, 2017

/home/jenkins-build/build/workspace/ceph-pull-requests/src/test/osd/osd-dup.sh:45: TEST_filestore_to_bluestore: return 1

I think try again and see the result.

@joscollin

This comment has been minimized.

Show comment
Hide comment
@joscollin

joscollin Jul 26, 2017

Member

Jenkins retest this please

Member

joscollin commented Jul 26, 2017

Jenkins retest this please

@joscollin

This comment has been minimized.

Show comment
Hide comment
@joscollin

joscollin Jul 26, 2017

Member

Jenkins retest this please

Member

joscollin commented Jul 26, 2017

Jenkins retest this please

@tchaikov tchaikov merged commit 3163e9b into ceph:master Jul 26, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment