Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: follow up to new options infrastructure #16527

Merged
merged 5 commits into from Jul 25, 2017

Conversation

Projects
None yet
5 participants
@jcsp
Copy link
Contributor

jcsp commented Jul 24, 2017

  • Break out the per-subsystem options and automatically assign the proper service to all of them.
  • Apply LEVEL_DEV to the obvious debug/injection cases
  • Correct the implementation of daemon defaults, and switch to using that mechanism for the special-cased settings in common init.

@jcsp jcsp added cleanup core labels Jul 24, 2017

@jcsp jcsp requested review from tchaikov and liewegas Jul 24, 2017

@tchaikov tchaikov added the needs-qa label Jul 24, 2017

@tchaikov tchaikov added this to the luminous milestone Jul 24, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Jul 24, 2017

Pushed additions:

  • reinstate FreeBSD ifdefs for defaults in options.cc
  • remove the defaults from legacy_config_opts.h -- this file is just used for generating fields, the defaults have been population from options.cc since it was added.

John Spray added some commits Jul 23, 2017

John Spray
common: separate out options by subsystem
This avoids compiler warning about one oversized
literal, allows us to add_service en-masse to
the whole collection, and avoids potential merge
conflicts when config changes in separate subsystems
are made.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
common/options: mark all obvious LEVEL_DEV options
This is everthing matching kill.*at, debug, inject.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
common: use code_environment_t for daemon-ness in config
...and reinstate the set_daemon_default versions of config options
in place of the special casing in common_init.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
common: reinstate freebsd ifdefs in options.cc
The automated conversion missed these.

Signed-off-by: John Spray <john.spray@redhat.com>
John Spray
common: remove dead default values from legacy opts
These were dead code and could cause confusion.

The actual default values live in options.cc since
it was added.

Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-options-followup branch from 7c02995 to 2867110 Jul 24, 2017

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Jul 24, 2017

retest this please

@jcsp

This comment has been minimized.

Copy link
Contributor Author

jcsp commented Jul 24, 2017

(jenkins failure was agent issue)

@jdurgin

This comment has been minimized.

Copy link
Member

jdurgin commented Jul 25, 2017

retest this please

1 similar comment
@liewegas

This comment has been minimized.

Copy link
Member

liewegas commented Jul 25, 2017

retest this please

@liewegas liewegas merged commit b4b51d1 into ceph:master Jul 25, 2017

2 of 4 checks passed

make check running make check
Details
make check (arm64) running make check
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.