New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: fix memory leaks during Swift Static Website's error handling. #16531

Merged
merged 1 commit into from Jul 27, 2017

Conversation

Projects
None yet
3 participants
@rzarzynski
Contributor

rzarzynski commented Jul 24, 2017

Fixes: http://tracker.ceph.com/issues/20757
Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jul 24, 2017

The patch passed Tempest locally.

@@ -401,7 +401,8 @@ int rgw_build_bucket_policies(RGWRados* store, struct req_state* s)
}
if(s->dialect.compare("s3") == 0) {
s->bucket_acl = new RGWAccessControlPolicy_S3(s->cct);
s->bucket_acl = std::unique_ptr<RGWAccessControlPolicy>(
new RGWAccessControlPolicy_S3(s->cct));

This comment has been minimized.

@cbodley

cbodley Jul 24, 2017

Contributor

consider using make_unique() for these (from common/backport14.h)

This comment has been minimized.

@rzarzynski

rzarzynski Jul 24, 2017

Contributor

I'm going to start loving this header. :-) Thanks, @cbodley!

rgw: fix memory leaks during Swift Static Website's error handling.
Fixes: http://tracker.ceph.com/issues/20757
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

@cbodley cbodley added the needs-qa label Jul 24, 2017

@rzarzynski

This comment has been minimized.

Contributor

rzarzynski commented Jul 26, 2017

jenkins retest this please (due to test_pidfile.sh and osd-dup.sh)

@yuriw yuriw merged commit 5fc9dfa into ceph:master Jul 27, 2017

4 checks passed

Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment