New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/tasks/ceph-deploy: Fix bluestore options for ceph-deploy #16571

Merged
merged 6 commits into from Jul 26, 2017

Conversation

Projects
None yet
3 participants
@vasukulkarni
Member

vasukulkarni commented Jul 25, 2017

a) add filestore/bluestore option to ceph-deploy task
b) Move the ceph-deploy options into its own folder (from root dir)
c) Add bluestore options to tests

@vasukulkarni vasukulkarni added the tests label Jul 25, 2017

vasukulkarni added some commits Jul 14, 2017

Add option to specify bluestore/filestore options
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Move ceph-deploy config options into its own folder
The old structure of link at top folder is pretty much outdated, the test
config option needs to be specific to cluster yaml.

Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Add bluestore overrides for ceph-deploy
ceph-deploy doesn't use ceph overrides, Add same overrides for ceph-deploy

Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
bluestore config options for tests
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>

@vasukulkarni vasukulkarni changed the title from [DNM] qa/tasks/ceph-deploy: Fix bluestore options for ceph-deploy to qa/tasks/ceph-deploy: Fix bluestore options for ceph-deploy Jul 25, 2017

@vasukulkarni

This comment has been minimized.

@vasukulkarni vasukulkarni requested review from liewegas and tmuthamizhan Jul 25, 2017

@vasukulkarni

This comment has been minimized.

@@ -20,3 +20,21 @@ overrides:
osd failsafe full ratio: .95
# this doesn't work with failures bc the log writes are not atomic across the two backends
# bluestore bluefs env mirror: true
ceph-deploy:
fs: xfs
bluestore: yes

This comment has been minimized.

@liewegas

liewegas Jul 25, 2017

Member

we probably need to add overrides to filestore-xfs.yaml in this same dir with filestore: true.. otherwise all tests willb e bluestore tests, since it's the new default, right?

This comment has been minimized.

@vasukulkarni

vasukulkarni Jul 25, 2017

Member

Thats true and currently thats the case (implicitly ceph-disk is using bluestore option). Adding that option to filestore-xfs and adding to ceph-deploy options will increase the tests from 24 to 48, Do you want to run those filestore tests as well for master?

This comment has been minimized.

@tmuthamizhan

tmuthamizhan Jul 25, 2017

Contributor

@vasukulkarni , why would adding ceph-deploy overrides to filestore-xfs.yaml increase the job count?
all it would do is make sure, we also have test coverage for ceph-deploy with filestore: true, right?

This comment has been minimized.

@vasukulkarni

vasukulkarni Jul 25, 2017

Member

@tmuthamizhan it has to be a separate test, test1 + bluestore.yaml and test1 + filestore.yaml, cant mix both configs in same test, so the suite will have to permute with that options within that folder.

@liewegas

This comment has been minimized.

Member

liewegas commented Jul 25, 2017

@tmuthamizhan

This comment has been minimized.

Contributor

tmuthamizhan commented Jul 25, 2017

@vasukulkarni , agree with @liewegas. job count shouldn't really matter.

vasukulkarni added some commits Jul 25, 2017

Add ceph-deploy overrides options
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
Add both filestore and bluestore options for tests
Signed-off-by: Vasu Kulkarni <vasu@redhat.com>
@tmuthamizhan

lgtm

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Jul 25, 2017

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Jul 25, 2017

retest this please

@vasukulkarni

This comment has been minimized.

Member

vasukulkarni commented Jul 26, 2017

@liewegas can you override the make check failure and merge this one?

@liewegas liewegas merged commit 56ffd7a into master Jul 26, 2017

3 of 4 checks passed

make check make check failed
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the wip-cd-bluestore-2 branch Jul 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment